fixed newline errors + snap tests

Author: Bertie690

crates/biome_cli/tests/snapshots/main_cases_rules_via_dependencies/enables_react_rules_via_dependencies.snap

@@ -25,7 +25,7 @@ function Component2() {
       console.log(local);
     }, [local, local]);
 }
-    
+
 ```
 
 # Termination Message
@@ -34,7 +34,7 @@ function Component2() {
 lint ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   × Some errors were emitted while running checks.
-  
+
 
 
 ```
@@ -45,104 +45,108 @@ lint ━━━━━━━━━━━━━━━━━━━━━━━━━
 test.jsx:4:10 lint/correctness/noUnusedVariables  FIXABLE  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! This function Component2 is unused.
-  
+
     2 │ import { useCallback } from "react";
-    3 │ 
+    3 │
   > 4 │ function Component2() {
       │          ^^^^^^^^^^
     5 │     const [local,SetLocal] = useState(0);
     6 │     const handle = useCallback(() => {
-  
+
   i Unused variables are often the result of an incomplete refactoring, typos, or other sources of bugs.
-  
+
   i Unsafe fix: If this is intentional, prepend Component2 with an underscore.
-  
+
      2  2 │   import { useCallback } from "react";
-     3  3 │   
+     3  3 │
      4    │ - function·Component2()·{
         4 │ + function·_Component2()·{
      5  5 │       const [local,SetLocal] = useState(0);
      6  6 │       const handle = useCallback(() => {
-  
+
 
 ```
 
 ```block
 test.jsx:5:18 lint/correctness/noUnusedVariables  FIXABLE  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! This variable SetLocal is unused.
-  
+
     4 │ function Component2() {
   > 5 │     const [local,SetLocal] = useState(0);
       │                  ^^^^^^^^
     6 │     const handle = useCallback(() => {
     7 │       console.log(local);
-  
+
   i Unused variables are often the result of an incomplete refactoring, typos, or other sources of bugs.
-  
+
   i Unsafe fix: If this is intentional, prepend SetLocal with an underscore.
-  
-     3  3 │   
+
+     3  3 │
      4  4 │   function Component2() {
      5    │ - ····const·[local,SetLocal]·=·useState(0);
         5 │ + ····const·[local,_SetLocal]·=·useState(0);
      6  6 │       const handle = useCallback(() => {
      7  7 │         console.log(local);
-  
+
 
 ```
 
 ```block
 test.jsx:6:11 lint/correctness/noUnusedVariables  FIXABLE  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! This variable handle is unused.
-  
+
     4 │ function Component2() {
     5 │     const [local,SetLocal] = useState(0);
   > 6 │     const handle = useCallback(() => {
       │           ^^^^^^
     7 │       console.log(local);
     8 │     }, [local, local]);
-  
+
   i Unused variables are often the result of an incomplete refactoring, typos, or other sources of bugs.
-  
+
   i Unsafe fix: If this is intentional, prepend handle with an underscore.
-  
+
      4  4 │   function Component2() {
      5  5 │       const [local,SetLocal] = useState(0);
      6    │ - ····const·handle·=·useCallback(()·=>·{
         6 │ + ····const·_handle·=·useCallback(()·=>·{
      7  7 │         console.log(local);
      8  8 │       }, [local, local]);
-  
+
 
 ```
 
 ```block
 test.jsx:6:20 lint/correctness/useExhaustiveDependencies  FIXABLE  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
-  × This hook specifies more dependencies than necessary: local
-  
+  × This hook specifies more dependencies than necessary: local.
+
     4 │ function Component2() {
     5 │     const [local,SetLocal] = useState(0);
   > 6 │     const handle = useCallback(() => {
       │                    ^^^^^^^^^^^
     7 │       console.log(local);
     8 │     }, [local, local]);
-  
+
   i This dependency can be removed from the list.
-  
+
      6 │     const handle = useCallback(() => {
      7 │       console.log(local);
    > 8 │     }, [local, local]);
        │                ^^^^^
      9 │ }
-    10 │     
-  
+    10 │
+
+  i React relies on hook dependencies to determine when to re-compute Effects.
+    Specifying more dependencies than required can lead to unnecessary re-rendering
+    and degraded performance.
+
   i Unsafe fix: Remove the extra dependencies from the list.
-  
+
     8 │ ····},·[local,·local]);
-      │              -------   
+      │              -------
 
 ```
 

crates/biome_js_analyze/src/lint/correctness/use_exhaustive_dependencies.rs

@@ -338,7 +338,7 @@ declare_lint_rule! {
     /// ```jsx,use_options
     /// function Foo() {
     ///   let stateVar = 1;
-    ///   // not used but still OK due to disabled rule
+    ///   // not used but still OK
     ///   useEffect(() => {}, [stateVar]);
     /// }
     /// ```
@@ -1008,7 +1008,7 @@ impl Rule for UseExhaustiveDependencies {
                         "This hook "<Emphasis>"does not specify"</Emphasis>" its dependency on "<Emphasis>{capture_text.as_ref()}</Emphasis>"."
                     },
                 ).note(markup! {
-                    "\nReact relies on hook dependencies to determine when to re-compute Effects."
+                    "React relies on hook dependencies to determine when to re-compute Effects."
                     "\nFailing to specify dependencies can result in Effects "<Emphasis>"not updating correctly"</Emphasis>" when state changes."
                     "\nThese \"stale closures\" are a common source of surprising bugs."
                     },
@@ -1046,9 +1046,9 @@ impl Rule for UseExhaustiveDependencies {
                     },
                 )
                 .note(markup! {
-                        "\nReact relies on hook dependencies to determine when to re-compute Effects."
+                        "React relies on hook dependencies to determine when to re-compute Effects."
                         "\nSpecifying more dependencies than required can lead to "<Emphasis>"unnecessary re-rendering"</Emphasis>
-                        " and "<Emphasis>"degraded performance"</Emphasis>"."
+                        "\nand "<Emphasis>"degraded performance"</Emphasis>"."
                     },
                 );
 

crates/biome_js_analyze/tests/specs/correctness/useExhaustiveDependencies/checkHooksImportedFromReact.js.snap

@@ -49,6 +49,10 @@ checkHooksImportedFromReact.js:3:9 lint/correctness/useExhaustiveDependencies  F
     5 │   }, []);
     6 │ 
   
+  i React relies on hook dependencies to determine when to re-compute Effects.
+    Failing to specify dependencies can result in Effects not updating correctly when state changes.
+    These "stale closures" are a common source of surprising bugs.
+  
   i Either include it or remove the dependency array.
   
   i Unsafe fix: Add the missing dependency to the list.

crates/biome_js_analyze/tests/specs/correctness/useExhaustiveDependencies/customHook.js.snap

@@ -45,6 +45,10 @@ customHook.js:5:5 lint/correctness/useExhaustiveDependencies  FIXABLE  ━━━
     7 │     }, []);
     8 │ 
   
+  i React relies on hook dependencies to determine when to re-compute Effects.
+    Failing to specify dependencies can result in Effects not updating correctly when state changes.
+    These "stale closures" are a common source of surprising bugs.
+  
   i Either include it or remove the dependency array.
   
   i Unsafe fix: Add the missing dependency to the list.
@@ -74,6 +78,10 @@ customHook.js:9:5 lint/correctness/useExhaustiveDependencies  FIXABLE  ━━━
     11 │     }, []);
     12 │ 
   
+  i React relies on hook dependencies to determine when to re-compute Effects.
+    Failing to specify dependencies can result in Effects not updating correctly when state changes.
+    These "stale closures" are a common source of surprising bugs.
+  
   i Either include it or remove the dependency array.
   
   i Unsafe fix: Add the missing dependency to the list.

crates/biome_js_analyze/tests/specs/correctness/useExhaustiveDependencies/duplicateDependencies.js.snap

@@ -24,7 +24,7 @@ function Component2() {
 ```
 duplicateDependencies.js:4:20 lint/correctness/useExhaustiveDependencies  FIXABLE  ━━━━━━━━━━━━━━━━━
 
-  × This hook specifies more dependencies than necessary: a
+  × This hook specifies more dependencies than necessary: a.
   
     3 │ function Component1({ a }) {
   > 4 │     const handle = useCallback(() => {
@@ -41,6 +41,10 @@ duplicateDependencies.js:4:20 lint/correctness/useExhaustiveDependencies  FIXABL
     7 │ }
     8 │ 
   
+  i React relies on hook dependencies to determine when to re-compute Effects.
+    Specifying more dependencies than required can lead to unnecessary re-rendering
+    and degraded performance.
+  
   i Unsafe fix: Remove the extra dependencies from the list.
   
     6 │ ····},·[a,·a]);
@@ -51,7 +55,7 @@ duplicateDependencies.js:4:20 lint/correctness/useExhaustiveDependencies  FIXABL
 ```
 duplicateDependencies.js:11:20 lint/correctness/useExhaustiveDependencies  FIXABLE  ━━━━━━━━━━━━━━━━
 
-  × This hook specifies more dependencies than necessary: local
+  × This hook specifies more dependencies than necessary: local.
   
      9 │ function Component2() {
     10 │     const [local,SetLocal] = useState(0);
@@ -68,6 +72,10 @@ duplicateDependencies.js:11:20 lint/correctness/useExhaustiveDependencies  FIXAB
        │                ^^^^^
     14 │ }
   
+  i React relies on hook dependencies to determine when to re-compute Effects.
+    Specifying more dependencies than required can lead to unnecessary re-rendering
+    and degraded performance.
+  
   i Unsafe fix: Remove the extra dependencies from the list.
   
     13 │ ····},·[local,·local]);

crates/biome_js_analyze/tests/specs/correctness/useExhaustiveDependencies/extraDependenciesInvalid.js.snap

@@ -50,7 +50,7 @@ function MyComponent3() {
 ```
 extraDependenciesInvalid.js:5:3 lint/correctness/useExhaustiveDependencies  FIXABLE  ━━━━━━━━━━━━━━━
 
-  × This hook specifies more dependencies than necessary: a
+  × This hook specifies more dependencies than necessary: a.
   
     3 │ function MyComponent() {
     4 │   let a = 1;
@@ -68,6 +68,10 @@ extraDependenciesInvalid.js:5:3 lint/correctness/useExhaustiveDependencies  FIXA
     6 │ }
     7 │ 
   
+  i React relies on hook dependencies to determine when to re-compute Effects.
+    Specifying more dependencies than required can lead to unnecessary re-rendering
+    and degraded performance.
+  
   i Unsafe fix: Remove the extra dependencies from the list.
   
     5 │ ··useEffect(()·=>·{},·[a]);
@@ -78,7 +82,7 @@ extraDependenciesInvalid.js:5:3 lint/correctness/useExhaustiveDependencies  FIXA
 ```
 extraDependenciesInvalid.js:12:3 lint/correctness/useExhaustiveDependencies  FIXABLE  ━━━━━━━━━━━━━━
 
-  × This hook specifies more dependencies than necessary: a, b
+  × This hook specifies more dependencies than necessary: a, b.
   
     10 │ function MyComponent2() {
     11 │   let a = 1, b = 1;
@@ -105,6 +109,10 @@ extraDependenciesInvalid.js:12:3 lint/correctness/useExhaustiveDependencies  FIX
     13 │ }
     14 │ 
   
+  i React relies on hook dependencies to determine when to re-compute Effects.
+    Specifying more dependencies than required can lead to unnecessary re-rendering
+    and degraded performance.
+  
   i Unsafe fix: Remove the extra dependencies from the list.
   
     12 │ ··useEffect(()·=>·{},·[a,·b]);
@@ -115,7 +123,7 @@ extraDependenciesInvalid.js:12:3 lint/correctness/useExhaustiveDependencies  FIX
 ```
 extraDependenciesInvalid.js:19:3 lint/correctness/useExhaustiveDependencies  FIXABLE  ━━━━━━━━━━━━━━
 
-  × This hook specifies more dependencies than necessary: a
+  × This hook specifies more dependencies than necessary: a.
   
     17 │ function MyComponent2() {
     18 │   const a = 1;
@@ -133,6 +141,10 @@ extraDependenciesInvalid.js:19:3 lint/correctness/useExhaustiveDependencies  FIX
     20 │ }
     21 │ 
   
+  i React relies on hook dependencies to determine when to re-compute Effects.
+    Specifying more dependencies than required can lead to unnecessary re-rendering
+    and degraded performance.
+  
   i Unsafe fix: Remove the extra dependencies from the list.
   
     19 │ ··useEffect(()·=>·{},·[a]);
@@ -143,7 +155,7 @@ extraDependenciesInvalid.js:19:3 lint/correctness/useExhaustiveDependencies  FIX
 ```
 extraDependenciesInvalid.js:28:3 lint/correctness/useExhaustiveDependencies ━━━━━━━━━━━━━━━━━━━━━━━━
 
-  × This hook specifies a dependency more specific that its captures: someObj.id
+  × This hook specifies a dependency more specific than its captures: someObj.id
   
     26 │ function MyComponent1() {
     27 │   let someObj = getObj();
@@ -194,6 +206,10 @@ extraDependenciesInvalid.js:28:3 lint/correctness/useExhaustiveDependencies  FIX
     30 │   }, [someObj.id]);
     31 │ }
   
+  i React relies on hook dependencies to determine when to re-compute Effects.
+    Failing to specify dependencies can result in Effects not updating correctly when state changes.
+    These "stale closures" are a common source of surprising bugs.
+  
   i Unsafe fix: Add the missing dependency to the list.
   
     30 │ ··},·[someObj.id,·someObj]);
@@ -204,7 +220,7 @@ extraDependenciesInvalid.js:28:3 lint/correctness/useExhaustiveDependencies  FIX
 ```
 extraDependenciesInvalid.js:36:3 lint/correctness/useExhaustiveDependencies  FIXABLE  ━━━━━━━━━━━━━━
 
-  × This hook specifies more dependencies than necessary: outer
+  × This hook specifies more dependencies than necessary: outer.
   
     34 │ // Dependencies from outer scope should not be valid
     35 │ function MyComponent3() {
@@ -222,6 +238,10 @@ extraDependenciesInvalid.js:36:3 lint/correctness/useExhaustiveDependencies  FIX
     39 │ }
     40 │ 
   
+  i React relies on hook dependencies to determine when to re-compute Effects.
+    Specifying more dependencies than required can lead to unnecessary re-rendering
+    and degraded performance.
+  
   i Unsafe fix: Remove the extra dependencies from the list.
   
     38 │ ··},·[outer]);

crates/biome_js_analyze/tests/specs/correctness/useExhaustiveDependencies/ignoredDependencies.js.snap

@@ -49,6 +49,10 @@ ignoredDependencies.js:8:5 lint/correctness/useExhaustiveDependencies  FIXABLE
     10 │     }, []);
     11 │ }
   
+  i React relies on hook dependencies to determine when to re-compute Effects.
+    Failing to specify dependencies can result in Effects not updating correctly when state changes.
+    These "stale closures" are a common source of surprising bugs.
+  
   i Either include it or remove the dependency array.
   
   i Unsafe fix: Add the missing dependency to the list.