fix(noInvalidUseBeforeDeclaration): don't report use before ambient var declaration (#8104)

Author: Conaclos

.changeset/some-brooms-pull.md

@@ -0,0 +1,13 @@
+---
+"@biomejs/biome": patch
+---
+
+Fixed [`noInvalidUseBeforeDeclaration`](https://biomejs.dev/linter/rules/no-invalid-use-before-declaration/).
+The rule no longer reports a use of an ambient variable before its declarations.
+The rule also completely ignores TypeScript declaration files.
+The following code is no longer reported as invalid:
+
+```ts
+CONSTANT;
+declare const CONSTANT: number;
+```

crates/biome_js_analyze/src/lint/correctness/no_invalid_use_before_declaration.rs

@@ -3,7 +3,8 @@ use biome_analyze::{Rule, RuleDiagnostic, RuleSource, context::RuleContext, decl
 use biome_console::markup;
 use biome_diagnostics::Severity;
 use biome_js_syntax::{
-    AnyJsExportNamedSpecifier, AnyJsIdentifierUsage,
+    AnyJsExportNamedSpecifier, AnyJsIdentifierUsage, JsFileSource, JsVariableDeclarationClause,
+    TsDeclareStatement,
     binding_ext::{AnyJsBindingDeclaration, AnyJsIdentifierBinding},
 };
 use biome_rowan::{AstNode, SyntaxNodeOptionExt, TextRange};
@@ -81,6 +82,13 @@ impl Rule for NoInvalidUseBeforeDeclaration {
     fn run(ctx: &RuleContext<Self>) -> Self::Signals {
         let model = ctx.model();
         let mut result = vec![];
+        let is_declaration_file = ctx
+            .source_type::<JsFileSource>()
+            .language()
+            .is_definition_file();
+        if is_declaration_file {
+            return Box::default();
+        }
         for binding in model.all_bindings() {
             let id = binding.tree();
             if matches!(
@@ -212,8 +220,21 @@ impl TryFrom<&AnyJsBindingDeclaration> for DeclarationKind {
             | AnyJsBindingDeclaration::JsArrayBindingPatternRestElement(_)
             | AnyJsBindingDeclaration::JsObjectBindingPatternProperty(_)
             | AnyJsBindingDeclaration::JsObjectBindingPatternRest(_)
-            | AnyJsBindingDeclaration::JsObjectBindingPatternShorthandProperty(_)
-            | AnyJsBindingDeclaration::JsVariableDeclarator(_) => Ok(Self::Variable),
+            | AnyJsBindingDeclaration::JsObjectBindingPatternShorthandProperty(_) => {
+                Ok(Self::Variable)
+            }
+            AnyJsBindingDeclaration::JsVariableDeclarator(declarator) => {
+                if let Some(var_decl) = declarator.declaration()
+                    && let Some(var_decl_clause) = var_decl.parent::<JsVariableDeclarationClause>()
+                    && var_decl_clause.parent::<TsDeclareStatement>().is_some()
+                {
+                    // Ambient variables, such as `declare const c;`,
+                    // can be used before their declarations.
+                    Err(())
+                } else {
+                    Ok(Self::Variable)
+                }
+            }
             // Parameters
             AnyJsBindingDeclaration::JsFormalParameter(_)
             | AnyJsBindingDeclaration::JsRestParameter(_)

crates/biome_js_analyze/tests/specs/correctness/noInvalidUseBeforeDeclaration/valid.ts

@@ -23,4 +23,5 @@ interface NestedBar {child:  {grandChild: {[FOO]: typeof FOO; enumFoo: EnumFoo}}
 const FOO = 'foo';
 enum EnumFoo {BAR = 'bar'}
 
-
+c;
+declare const c: number;

crates/biome_js_analyze/tests/specs/correctness/noInvalidUseBeforeDeclaration/valid.ts.snap

@@ -1,6 +1,5 @@
 ---
 source: crates/biome_js_analyze/tests/spec_tests.rs
-assertion_line: 135
 expression: valid.ts
 ---
 # Input
@@ -30,6 +29,7 @@ interface NestedBar {child:  {grandChild: {[FOO]: typeof FOO; enumFoo: EnumFoo}}
 const FOO = 'foo';
 enum EnumFoo {BAR = 'bar'}
 
-
+c;
+declare const c: number;
 
 ```