Skip to content

Commit 5b69680

Browse files
authored
Merge pull request #635 from ypriverol/dev
small changes for release
2 parents 56db5be + 2f52c34 commit 5b69680

File tree

2 files changed

+13
-5
lines changed

2 files changed

+13
-5
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1515
- [627](https://github.com/bigbio/quantms/pull/627) Move thermorawfileparser from local to bigbio nf-core
1616
- [629](https://github.com/bigbio/quantms/pull/629) Update quantms-rescoring to 0.0.13 to support transfer learning
1717
- [615](https://github.com/bigbio/quantms/pull/615) Update quantms-utils 0.0.24 and pmultiqc 0.0.39
18+
- [614](https://github.com/bigbio/quantms/pull/614) enable_diann_mztab from true to false as default. For DIA pipelines the mzTab will not be generated unless specified by a parameter `--enable_diann_mztab true`.
19+
- [635](https://github.com/bigbio/quantms/pull/635) Minimum Nextflow version requirement updated to `>=25.04.0`
1820

1921
### `Fixed`
2022

@@ -28,6 +30,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
2830
- Updated pyonsite==0.0.2
2931
- Updated quantms-utils==0.0.24
3032

33+
### `Deprecations`
34+
35+
- [626](https://github.com/bigbio/quantms/pull/626) Removed luciphor-specific parameters: `luciphor_neutral_losses`, `luciphor_decoy_mass`, `luciphor_decoy_neutral_losses`. These have been replaced with onsite parameters: `onsite_neutral_losses`, `onsite_decoy_mass`, `onsite_decoy_neutral_losses`. The new onsite module provides support for multiple PTM localization algorithms (AScore, PhosphoRS, and LucXor) with unified parameter naming.
36+
3137
## [1.6.0] bigbio/quantms - [13/08/2025] - Munich
3238

3339
### `Added`

modules/local/utils/msrescore_features/main.nf

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,13 +48,15 @@ process MSRESCORE_FEATURES {
4848
// ms2pip only supports Da unit
4949
ms2_tolerance_unit = 'Da'
5050
ms2_tolerance = params.ms2features_tolerance
51-
if (meta['fragmentmasstoleranceunit'].toLowerCase().endsWith('da')) {
51+
def fragment_unit_lower = meta['fragmentmasstoleranceunit'].toLowerCase()
52+
if (fragment_unit_lower.endsWith('da')) {
5253
ms2_tolerance = meta['fragmentmasstolerance']
53-
} else if (params.ms2features_tolerance_unit == 'ppm') {
54-
log.info "Warning: MS2pip only supports Da unit. Using default from config!"
55-
ms2_tolerance = 0.05
54+
} else if (fragment_unit_lower == 'ppm' || params.ms2features_tolerance_unit == 'ppm') {
55+
log.warn "Warning: MS2pip only supports Da unit. Using default from config!"
56+
ms2_tolerance = params.ms2features_tolerance
5657
} else {
57-
log.info "Warning: MS2pip only supports Da unit. Using default from config!"
58+
log.warn "Warning: MS2pip only supports Da unit. Fragment mass tolerance unit '${meta['fragmentmasstoleranceunit']}' is not supported. Using default from config! In the future, please use 'Da' or 'ppm'."
59+
ms2_tolerance = params.ms2features_tolerance
5860
}
5961
}
6062

0 commit comments

Comments
 (0)