Remove onceIO

Author: berberman

.github/workflows/bench.yml

@@ -4,6 +4,7 @@ on:
   pull_request:
     branches:
       - '**'
+  push:
 
 jobs:
   pre_job:

ghcide/src/Development/IDE/Plugin/CodeAction/Args.hs

@@ -54,27 +54,25 @@ runGhcideCodeAction :: LSP.MonadLsp Config m => IdeState -> MessageParams TextDo
 runGhcideCodeAction state (CodeActionParams _ _ (TextDocumentIdentifier uri) _range CodeActionContext {_diagnostics = List diags}) codeAction = do
   let mbFile = toNormalizedFilePath' <$> uriToFilePath uri
       runRule key = runAction ("GhcideCodeActions." <> show key) state $ runMaybeT $ MaybeT (pure mbFile) >>= MaybeT . use key
-  caaExportsMap <-
-    onceIO $
-      runRule GhcSession >>= \case
-        Just env -> do
-          pkgExports <- envPackageExports env
-          localExports <- readVar (exportsMap $ shakeExtras state)
-          pure $ localExports <> pkgExports
-        _ -> pure mempty
-  caaIdeOptions <- onceIO $ runAction "GhcideCodeActions.getIdeOptions" state getIdeOptions
-  caaParsedModule <- onceIO $ runRule GetParsedModule
-  caaContents <-
-    onceIO $
-      runRule GetFileContents >>= \case
-        Just (_, txt) -> pure txt
-        _             -> pure Nothing
-  caaDf <- onceIO $ fmap (ms_hspp_opts . pm_mod_summary) <$> caaParsedModule
-  caaAnnSource <- onceIO $ runRule GetAnnotatedParsedSource
-  caaTmr <- onceIO $ runRule TypeCheck
-  caaHar <- onceIO $ runRule GetHieAst
-  caaBindings <- onceIO $ runRule GetBindings
-  caaGblSigs <- onceIO $ runRule GetGlobalBindingTypeSigs
+      caaExportsMap =
+          runRule GhcSession >>= \case
+            Just env -> do
+              pkgExports <- envPackageExports env
+              localExports <- readVar (exportsMap $ shakeExtras state)
+              pure $ localExports <> pkgExports
+            _ -> pure mempty
+      caaIdeOptions = runAction "GhcideCodeActions.getIdeOptions" state getIdeOptions
+      caaParsedModule = runRule GetParsedModule
+      caaContents =
+          runRule GetFileContents >>= \case
+            Just (_, txt) -> pure txt
+            _             -> pure Nothing
+      caaDf = fmap (ms_hspp_opts . pm_mod_summary) <$> caaParsedModule
+      caaAnnSource = runRule GetAnnotatedParsedSource
+      caaTmr = runRule TypeCheck
+      caaHar = runRule GetHieAst
+      caaBindings = runRule GetBindings
+      caaGblSigs = runRule GetGlobalBindingTypeSigs
   liftIO $
     concat
       <$> sequence
@@ -146,15 +144,6 @@ data CodeActionArgs = CodeActionArgs
     caaDiagnostic   :: Diagnostic
   }
 
--- | There's no concurrency in each provider,
--- so we don't need to be thread-safe here
-onceIO :: MonadIO m => IO a -> m (IO a)
-onceIO io = do
-  var <- liftIO $ newIORef Nothing
-  pure $
-    readIORef var >>= \case
-      Just x -> pure x
-      _      -> io >>= \x -> writeIORef' var (Just x) >> pure x
 
 -------------------------------------------------------------------------------------------------