Fix stack-use-after-scope in ParagraphTest.GetWordBoundaryParagraph

bdero · bdero · commit 5542c04fdebc · 2021-08-17T12:25:32.000-07:00
diff --git a/third_party/txt/src/txt/paragraph_txt.cc b/third_party/txt/src/txt/paragraph_txt.cc
@@ -1992,7 +1992,8 @@ Paragraph::Range<size_t> ParagraphTxt::GetWordBoundary(size_t offset) {
       return Range<size_t>(0, 0);
   }
 
-  word_breaker_->setText(icu::UnicodeString(false, text_.data(), text_.size()));
+  auto unicode_text = icu::UnicodeString(false, text_.data(), text_.size());
+  word_breaker_->setText(unicode_text);
 
   int32_t prev_boundary = word_breaker_->preceding(offset + 1);
   int32_t next_boundary = word_breaker_->next();

Original file line number	Diff line number	Diff line change
`@@ -1992,7 +1992,8 @@ Paragraph::Range<size_t> ParagraphTxt::GetWordBoundary(size_t offset) {`
`1992`	`1992`	`return Range<size_t>(0, 0);`
`1993`	`1993`	`}`
`1994`	`1994`
`1995`		`- word_breaker_->setText(icu::UnicodeString(false, text_.data(), text_.size()));`
	`1995`	`+ auto unicode_text = icu::UnicodeString(false, text_.data(), text_.size());`
	`1996`	`+ word_breaker_->setText(unicode_text);`
`1996`	`1997`
`1997`	`1998`	`int32_t prev_boundary = word_breaker_->preceding(offset + 1);`
`1998`	`1999`	`int32_t next_boundary = word_breaker_->next();`