This repository was archived by the owner on Nov 4, 2021. It is now read-only.
FIX conflict with Laravel 6.8 #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove -s option for searchable model generation to fix compatibility with laravel 6.8
julienarcin
changed the title
sarperkaya
approved these changes
Dec 18, 2019
JamesFreeman
approved these changes
Dec 18, 2019
beingjungshahi
approved these changes
Dec 18, 2019
|
@babenkoivan please review this pull request. |
nuernbergerA
approved these changes
Dec 18, 2019
slowdream
approved these changes
Dec 18, 2019
msalahat88
approved these changes
Dec 18, 2019
joearcher
approved these changes
Dec 18, 2019
khanhvu14
approved these changes
Dec 19, 2019
|
@lucasmichot can you please review this pull request because we are having issue after Laravel 6.8 update. |
mobde3
approved these changes
Dec 19, 2019
AbdullahObaid
approved these changes
Dec 19, 2019
raymondtri
approved these changes
Dec 19, 2019
bagf
approved these changes
Dec 19, 2019
|
@babenkoivan Any chance this could be reviewed ASAP as it's preventing people from upgrading to the latest versions of Laravel? |
ivan770
approved these changes
Dec 20, 2019
lucasmichot
approved these changes
Dec 20, 2019
AmirrezaNasiri
approved these changes
Dec 28, 2019
|
@babenkoivan I'm merging this PR since it's simple and causes no breaking changes. |
|
Merged and released on v4.0.2 |
|
Is it possible to have this backported to 3.x for those of us that can't upgrade to 4.x of the package because it's targeting ElasticSearch 7. We're doing some container hacks to override for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove -s option for searchable model generation to fix compatibility with laravel 6.8
Issue : 305