Allow replacement of simple shape types in ModelTransformer#900
Merged
JordonPhillips merged 2 commits intosmithy-lang:mainfrom Sep 2, 2021
jdisanti:transform-replace-simple-shapes
Merged
Allow replacement of simple shape types in ModelTransformer#900JordonPhillips merged 2 commits intosmithy-lang:mainfrom jdisanti:transform-replace-simple-shapes
JordonPhillips merged 2 commits intosmithy-lang:mainfrom
jdisanti:transform-replace-simple-shapes
Conversation
jdisanti
requested review from
DavidOgunsAWS,
JordonPhillips,
kstich and
mtdowling
as code owners
This was referenced Aug 31, 2021
JordonPhillips
requested changes
Sep 1, 2021
smithy-model/src/main/java/software/amazon/smithy/model/transform/ReplaceShapes.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Jordon Phillips <JordonPhillips@users.noreply.github.com>
JordonPhillips
approved these changes
Sep 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: No issue
Description of changes:
The AWS Rust SDK needs to customize S3's
Sizeshape to be aLongShapeinstead of anIntegerShapeso that larger files can be successfully represented in responses (see awslabs/aws-sdk-rust#209). This change updatesReplaceShapesto allow simple shape changes like this, as well asListShape <-> SetShapechanges.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.