add test for rpc protocol path preix#899
Merged
adamthom-amzn merged 1 commit intosmithy-lang:mainfrom Aug 31, 2021
Merged
Conversation
AllanZhengYP
requested review from
DavidOgunsAWS,
JordonPhillips,
kstich and
mtdowling
as code owners
adamthom-amzn
suggested changes
Aug 30, 2021
Contributor
adamthom-amzn
left a comment
adamthom-amzn
left a comment
There was a problem hiding this comment.
The commit message has a typo - "preix" should be "prefix"
smithy-aws-protocol-tests/model/awsJson1_0/endpoint-paths.smithy
Outdated
Show resolved
Hide resolved
AllanZhengYP
force-pushed
the
rpc-path-prefix
branch
from
2eb859c to
cb4a243
Compare
AllanZhengYP
force-pushed
the
rpc-path-prefix
branch
from
cb4a243 to
b93f438
Compare
JordonPhillips
approved these changes
Aug 31, 2021
adamthom-amzn
approved these changes
Aug 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Followup to smithy-lang/smithy-typescript#406. Add protocol test for RPC protocols path prefix support.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.