Malformed request tests for timestamps#882
Merged
adamthom-amzn merged 1 commit intosmithy-lang:mainfrom Aug 9, 2021
Merged
Conversation
JordonPhillips
approved these changes
Aug 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
This is basically a really verbose matrix test. There are four files: one for body, header, query, and path. Each has three operations: one for whatever the default is for that type of member, and two more for the other two formats that aren't the default. The tests are essentially the same in every location, modulo formatting and where the value is injected. This is probably overkill, but it ensures that we don't have a server implementation where the validation of timestamps varies based on location.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.