Merged
Conversation
kstich
reviewed
Aug 3, 2021
smithy-model/src/main/resources/software/amazon/smithy/model/loader/prelude.smithy
Outdated
Show resolved
Hide resolved
JordonPhillips
force-pushed
the
deprecate-unique-items
branch
from
256cbbd to
31f9f51
Compare
JordonPhillips
force-pushed
the
deprecate-unique-items
branch
from
31f9f51 to
2650e75
Compare
kstich
approved these changes
Aug 6, 2021
mtdowling
reviewed
Aug 9, 2021
mtdowling
reviewed
Aug 9, 2021
JordonPhillips
force-pushed
the
deprecate-unique-items
branch
from
e302ba3 to
8bd5f8c
Compare
JordonPhillips
force-pushed
the
deprecate-unique-items
branch
from
8bd5f8c to
701f00c
Compare
mtdowling
approved these changes
Aug 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This deprecates the
uniqueItemstrait in favor of having ordered sets. Note: this PR is currently against theidl-1.1branch.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.