Merged
Conversation
- Change `must` to `SHOULD` in reference to the suffix of `api`, `client`, and `service - Add guidance to remove the suffix for new SDK versions
mtdowling
reviewed
Jun 28, 2021
rcoh
added a commit
to smithy-lang/smithy-rs
that referenced
this pull request
Jun 28, 2021
Co-authored-by: Michael Dowling <mtdowling@gmail.com>
mtdowling
approved these changes
Jun 29, 2021
rcoh
added a commit
to smithy-lang/smithy-rs
that referenced
this pull request
Jun 30, 2021
* Strip the service/api/client suffix from sdkId See smithy-lang/smithy#848 * Add Cargo.toml to SDK output dir
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
musttoSHOULDin reference to the suffix ofapi,client, and `serviceBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.