Setup cross platform builds of the CLI#832
Merged
Conversation
This commit adds support for cross platform builds of the CLI using jlink via each support version of JDK 16 of Amazon Corretto (we'll bump to JDK 17 when it's available). Each supported build target is built by downloading the appropriate JDK from Corretto and running jlink. The Dockerfile has been updated to now use the prebuilt binary for linux-x86_64, and will now use application class data sharing to improve CLI startup time in the Docker container. A couple dependencies were updated, including Gradle, in order to build on JDK 16. JDK 16 also complained about creating an explicitly boxed value, so that was addressed too. Future work should include building signed tar.gz and zip files, creating a Mac pkg file via jpackage, and creating an msi via jpackage.
kstich
approved these changes
Jun 14, 2021
JordonPhillips
requested changes
Jun 14, 2021
JordonPhillips
approved these changes
Jun 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds support for cross platform builds of the CLI using
jlink via each support version of JDK 16 of Amazon Corretto (we'll bump
to JDK 17 when it's available). Each supported build target is built by
downloading the appropriate JDK from Corretto and running jlink.
The Dockerfile has been updated to now use the prebuilt binary for
linux-x86_64, and will now use application class data sharing to improve
CLI startup time in the Docker container.
A couple dependencies were updated, including Gradle, in order to build
on JDK 16. JDK 16 also complained about creating an explicitly boxed
value, so that was addressed too.
Future work should include building signed tar.gz and zip files, creating a
Mac pkg file via jpackage, and creating an msi via jpackage.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.