Validate known media types in protocol tests#822
Merged
Conversation
mtdowling
requested review from
JordonPhillips,
kstich and
srchase
as code owners
kstich
requested changes
Jun 9, 2021
Contributor
kstich
left a comment
kstich
left a comment
There was a problem hiding this comment.
Looks like the valid-xml.smithy file is empty.
This commit updates protocol test validators to ensure that known media types for XML and JSON contain valid content. Closes #821
mtdowling
force-pushed
the
validate-protocol-test-bodies
branch
from
0ffb31e to
dee3a0b
Compare
kstich
approved these changes
Jun 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates protocol test validators to ensure that known media
types for XML and JSON contain valid content.
Closes #821
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.