Remove falsely set empty bodies for restJson1#765
Merged
JordonPhillips merged 1 commit intosmithy-lang:mainfrom Apr 8, 2021
Merged
Remove falsely set empty bodies for restJson1#765JordonPhillips merged 1 commit intosmithy-lang:mainfrom
JordonPhillips merged 1 commit intosmithy-lang:mainfrom
Conversation
A number of tests for restJson1, notably tests that only set headers, had the expected response body set to an empty string. These actually would need to be empty json objects since restJson1 operations with a defined output shape always need to send something. This just removes the body entry in the tests since that behavior is covered by more specific tests.
JordonPhillips
requested review from
kstich,
mtdowling and
srchase
as code owners
srchase
approved these changes
Apr 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A number of tests for restJson1, notably tests that only set headers,
had the expected response body set to an empty string. These actually
would need to be empty json objects since restJson1 operations with
a defined output shape always need to send something. This just
removes the body entry in the tests since that behavior is covered
by more specific tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.