Add protocol tests for String & Enum HTTP payloads#747
Merged
kstich merged 3 commits intosmithy-lang:mainfrom Mar 31, 2021
Merged
Add protocol tests for String & Enum HTTP payloads#747kstich merged 3 commits intosmithy-lang:mainfrom
kstich merged 3 commits intosmithy-lang:mainfrom
Conversation
kstich
reviewed
Mar 29, 2021
Contributor
kstich
left a comment
kstich
left a comment
There was a problem hiding this comment.
Thanks for adding these!
Would you be willing to add a couple tests for responses? No worries if not, we can add them after as well.
Contributor
Author
|
yeah I have them locally actually, let me copy them over |
kstich
approved these changes
Mar 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes: There are no protocol tests for Strings or enum-marked-strings for restJson.
Tests: The Rust SDK passes these tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.