Conversation
kstich
requested changes
Mar 10, 2021
...n/java/software/amazon/smithy/model/validation/validators/HttpQueryParamsTraitValidator.java
Show resolved
Hide resolved
smithy-model/src/test/java/software/amazon/smithy/model/knowledge/HttpBindingIndexTest.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/knowledge/HttpBindingIndex.java
Outdated
Show resolved
Hide resolved
...n/java/software/amazon/smithy/model/validation/validators/HttpQueryParamsTraitValidator.java
Outdated
Show resolved
Hide resolved
srchase
force-pushed
the
httpQueryParams
branch
from
5429423 to
a222872
Compare
kstich
reviewed
Mar 11, 2021
...n/java/software/amazon/smithy/model/validation/validators/HttpQueryParamsTraitValidator.java
Outdated
Show resolved
Hide resolved
...n/java/software/amazon/smithy/model/validation/validators/HttpQueryParamsTraitValidator.java
Outdated
Show resolved
Hide resolved
...n/java/software/amazon/smithy/model/validation/validators/HttpQueryParamsTraitValidator.java
Outdated
Show resolved
Hide resolved
.../src/main/java/software/amazon/smithy/openapi/fromsmithy/protocols/AbstractRestProtocol.java
Outdated
Show resolved
Hide resolved
srchase
force-pushed
the
httpQueryParams
branch
from
a222872 to
0c8b403
Compare
JordonPhillips
requested changes
Mar 11, 2021
JordonPhillips
approved these changes
Mar 11, 2021
mtdowling
requested changes
Mar 11, 2021
...n/java/software/amazon/smithy/model/validation/validators/HttpQueryParamsTraitValidator.java
Outdated
Show resolved
Hide resolved
...n/java/software/amazon/smithy/model/validation/validators/HttpQueryParamsTraitValidator.java
Outdated
Show resolved
Hide resolved
.../src/main/java/software/amazon/smithy/openapi/fromsmithy/protocols/AbstractRestProtocol.java
Outdated
Show resolved
Hide resolved
mtdowling
reviewed
Mar 12, 2021
.../src/main/java/software/amazon/smithy/openapi/fromsmithy/protocols/AbstractRestProtocol.java
Outdated
Show resolved
Hide resolved
mtdowling
reviewed
Mar 12, 2021
...n/java/software/amazon/smithy/model/validation/validators/HttpQueryParamsTraitValidator.java
Outdated
Show resolved
Hide resolved
mtdowling
approved these changes
Mar 12, 2021
srchase
force-pushed
the
httpQueryParams
branch
from
fa5e507 to
71fa01e
Compare
kstich
requested changes
Mar 13, 2021
kstich
approved these changes
Mar 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
httpQueryParamstrait that binds a map of key-value pairs to be added as query string parameters.The trait is supported when converting to OpenAPI by using the
formparameter style.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.