Add docs/tests for Glacier customizations#704
Merged
kstich merged 4 commits intosmithy-lang:mainfrom Feb 4, 2021
Merged
Conversation
This adds documentation and protocol tests for the customizations required to generate Glacier client.
JordonPhillips
force-pushed
the
aws-service-protocol-tests
branch
from
389d619 to
f69642e
Compare
kstich
requested changes
Feb 4, 2021
kstich
approved these changes
Feb 4, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds documentation and protocol tests for the customizations required to generate Glacier client.
For the protocol tests, I included a representative subset of the Glacier model with protocol tests added in. I'm unsure if this is the right strategy though. The other option would be to include the entire model. That would reduce the risk of excluding too much, but also potentially results in having some truly massive models buried in this repo.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.