Conversation
There was a problem hiding this comment.
Slightly darker to be visible in dark background table rows without being obnoxious in light backgrounds.
kstich
force-pushed
the
query_protocol_docs
branch
from
539d9f2 to
0adcb0e
Compare
There was a problem hiding this comment.
Specifically the operation's shape name ( :token:`shape name ` )
There was a problem hiding this comment.
parameter -> member ?
There was a problem hiding this comment.
These could use inlined examples
There was a problem hiding this comment.
specifically the string member. The mixing of quotes and ticks is a bit odd here. The same applies the the other entries
There was a problem hiding this comment.
To what are the traits applied
ditto for member and structure
There was a problem hiding this comment.
Please define how one serializes a null value. Also empty string
There was a problem hiding this comment.
The wording in the request section is better as it calls out that this protocol specifically doesn't support it
There was a problem hiding this comment.
These could also use inline examples, or links to the specific sections of the serializing xml shapes page
This fleshes out the documentation for the `awsQuery` protocol.
kstich
force-pushed
the
query_protocol_docs
branch
4 times, most recently
from
0359a7b to
acc2c04
Compare
There was a problem hiding this comment.
These traits should be ref'd
There was a problem hiding this comment.
The s in errors should be lowercased
There was a problem hiding this comment.
This should show up in normal query too
This adds documentation for ec2Query by abstracting out the docs for awsQuery and including substitutions for the differences. Examples for awsQuery have been added as well.
kstich
force-pushed
the
query_protocol_docs
branch
from
acc2c04 to
1f28d6f
Compare
2 participants
This fleshes out the documentation for the
awsQueryprotocol.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.