Add test for map of sets to restJson protocol test.#684
Merged
Conversation
kstich
requested changes
Jan 8, 2021
mtdowling
force-pushed
the
add-set-in-map-jsonRest
branch
from
1bebdd4 to
ad6d0a8
Compare
mtdowling
approved these changes
Jun 11, 2021
kstich
approved these changes
Jun 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
Adds a test to exersize a nested set within a map for
restJson1protocol. I had implemented some serialization code but forgot about nested Sets. Protocol tests as-is didn't catch this case.Testing Done
./gradlew testBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.