Conversation
kstich
requested changes
Sep 3, 2020
smithy-model/src/main/java/software/amazon/smithy/model/selector/PathFinder.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/selector/PathFinder.java
Outdated
Show resolved
Hide resolved
This commit fixes a bug in TopologicalIndex where some forms of recursion weren't detected, which resulted in a stack overflow. This was because directly recursive shapes were found, but transitively recursive shapes were not (shapes that are recursive on themselves, but enter into a cycle because they reference recursive shapes). To address this, TopologicalIndex was rewritten to just implement a DFS rather than try to reuse PathFinder.
mtdowling
force-pushed
the
fix-topologic-index
branch
from
3615c8f to
19c40cb
Compare
AllanZhengYP
approved these changes
Sep 3, 2020
kstich
approved these changes
Sep 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug in TopologicalIndex where some forms of
recursion weren't detected, which resulted in a stack overflow. This was
because directly recursive shapes were found, but transitively recursive
shapes were not (shapes that are recursive on themselves, but enter into
a cycle because they reference recursive shapes). To address this,
TopologicalIndex was rewritten to just implement a DFS rather than try
to reuse PathFinder.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.