Merged
Conversation
This commit deprecates the old access pattern used to create a KnowledgeIndex (`model.getKnowledge(X.class)`) in favor of using a new convention: `X.of(model)`. KnowledgeIndex implementations are now expected to provide a public static method named `of` that accepts a `Model` and returns an instance of the class. The instance should be created by calling `model.getKnowledge(Class<T>, Function<Model, T>)` which will ensure the index is cached in the given model. This change is the first step towards seeing if we can get full GraalVM native image support. It also makes using a KnowledgeIndex more ergonomic IMO, and remove reflection, which is generally a good thing. The deprecated method will eventually be removed in a subsequent release.
kstich
approved these changes
Aug 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit deprecates the old access pattern used to create a
KnowledgeIndex (
model.getKnowledge(X.class)) in favor of using a newconvention:
X.of(model). KnowledgeIndex implementations are nowexpected to provide a public static method named
ofthat accepts aModeland returns an instance of the class. The instance should becreated by calling
model.getKnowledge(Class<T>, Function<Model, T>)which will ensure the index is cached in the given model.
This change is the first step towards seeing if we can get full GraalVM
native image support. It also makes using a KnowledgeIndex more
ergonomic IMO, and remove reflection, which is generally a good thing.
The deprecated method will eventually be removed in a subsequent
release.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.