Update REST-JSON protocol test implicit request body case#476
Merged
mtdowling merged 1 commit intosmithy-lang:masterfrom Jun 24, 2020
Merged
Update REST-JSON protocol test implicit request body case#476mtdowling merged 1 commit intosmithy-lang:masterfrom
mtdowling merged 1 commit intosmithy-lang:masterfrom
Conversation
Updates the restJson1 protocol test to not expect `{}` as the request
body. Instead the test expects no/empty request body. This matches the AWS SDK's
expectation of REST-JSON with no input parameters when no document or
payload binding are modeled on the input shape.
https://github.com/aws/aws-sdk-go-v2/blob/master/models/protocol_tests/input/rest-json.json#L3-L19
mtdowling
approved these changes
Jun 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the restJson1 protocol test to not expect
{}as the request body. Instead the test expects no/empty request body. This matches the AWS SDK's expectation of REST-JSON with no input parameters when no document or payload binding are modeled on the input shape.https://github.com/aws/aws-sdk-go-v2/blob/master/models/protocol_tests/input/rest-json.json#L724-L737
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.