Convert awsjson protocol tests to Smithy IDL#472
Merged
JordonPhillips merged 3 commits intosmithy-lang:masterfrom Jun 23, 2020
Merged
Convert awsjson protocol tests to Smithy IDL#472JordonPhillips merged 3 commits intosmithy-lang:masterfrom
JordonPhillips merged 3 commits intosmithy-lang:masterfrom
Conversation
This converts the aws json protocol tests to the Smithy IDL. This includes no changes, not even to use the shared shapes.
This breaks up the aws json protocol test operations into their own files. This helps a bit to make them easier to read, though the kitchen sink operation being so big is not helpful in that regard.
mtdowling
approved these changes
Jun 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
This converts the aws json protocol tests to the smithy idl so that they're easier to update. It was converted using the idl serializer (first commit) then updated to remove an unnecessary suppression (second commit) and break the operations out into their own files (third commit).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.