Conversation
This commit updates selectors to tolerate unknown functions and renames the ":each" selector to ":is" to match the CSS4 name of ":is", which is the same functionality. Support for ":each" is still present and functions as an alias.
The "!=" attribute comparator is used to find shapes that have an attribute, but the attribute is not equal to a given value. For example, the following selector: ``` [trait|error!=client] ``` Is a simplification of the following: ``` [trait|error]:not([trait|error=client]) ```
Nested trait properties can be selected using a "|" delimited syntax. Values or lists and objects can be "projected" using the special `(values)` property. Keys of objects can be projected using the special `(keys)` property.
* Fix "~=" in docs to properly reference "^=".
* Rewrite Selector parser to be more restrictive and fix several bugs.
* Adds support for numbers in attribute selectors.
* Shape IDs with members must be quoted.
* The parser and grammar are more resilient to unknown attributes,
functions, and attribute paths.
* pseudo-properties are now formalized in the grammar and parser as
`"(" identifier ")"`, allowing us to add more in the future as needed.
kstich
requested changes
Apr 20, 2020
kstich
approved these changes
Apr 20, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds several new features to selectors, updates its grammar, and rewrites the parser to be more adaptable to change.
>,>=,<,<=. This can be used to find out things like[trait|httpError >= 500].!=to check if an attribute exists but isn't equal to the given value.The "!=" attribute comparator is used to find shapes that have an attribute, but the attribute is not equal to a given value. For example, the following selector:
[trait|error!=client], is a simplification of the following:[trait|error]:not([trait|error=client])[trait|httpError = 500, 501].$=comparator.(values)property. Keys of objects can be projected using the special(keys)property."(" identifier ")", allowing us to add more in the future as needed.