Warn don't fail on additional properties#374
Merged
Conversation
This PR updates Smithy's loaders to not fail on additional properties, but rather, warn. This allows new features to be added in the future that might not materially change the model but do need new properties added to shapes (like a new resource method, structure parent, etc). Further, various traits were emitting warnings both to a logger and to the validator because they were manually asserting that traits don't have additional properties. This is unnecessary since this is already handled automatically for every trait. This commit removes those redundant checks.
kstich
approved these changes
Apr 16, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates Smithy's loaders to not fail on additional properties,
but rather, warn. This allows new features to be added in the future
that might not materially change the model but do need new properties
added to shapes (like a new resource method, structure parent, etc).
Further, various traits were emitting warnings both to a logger and to
the validator because they were manually asserting that traits don't
have additional properties. This is unnecessary since this is already
handled automatically for every trait. This commit removes those
redundant checks.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.