Merged
Conversation
The HttpBindingIndex now knows about event streams and can return an eventstream specific media type when an operation's input or output uses one. This is now used as part of the OpenAPI converter so that the generated OpenAPI description uses an appropriate media type. AbstractRestProtocol was updated to add a method for returning the media type of an EventStreamInfo object, with a default implementation that returns application/vnd.amazon.eventstream. Since event streams are now supported, the UnsupportedTraits mapper was updated to allow event streams and streams. However, endpoint and hostLabel traits are not supported, so they were added into the mapper.
kstich
approved these changes
Mar 31, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HttpBindingIndex now knows about event streams and can return an
eventstream specific media type when an operation's input or output uses
one. This is now used as part of the OpenAPI converter so that the
generated OpenAPI description uses an appropriate media type.
AbstractRestProtocol was updated to add a method for returning the media
type of an EventStreamInfo object, with a default implementation that
returns application/vnd.amazon.eventstream.
Since event streams are now supported, the UnsupportedTraits mapper was
updated to allow event streams and streams. However, endpoint and
hostLabel traits are not supported, so they were added into the mapper.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.