[0.10] Clean up LoaderVisitor and IDL loading#287
Merged
Conversation
mtdowling
changed the title
kstich
reviewed
Feb 24, 2020
smithy-model/src/main/java/software/amazon/smithy/model/loader/ModelAssembler.java
Outdated
Show resolved
Hide resolved
mtdowling
force-pushed
the
reduce-forward-reference-lookups
branch
from
cd89c44 to
1e1e4fa
Compare
This commit ensures that JSON IDL models are loaded before IDL models to reduce forward reference lookups when loading IDL models.
kstich
approved these changes
Feb 24, 2020
This commit moves all IDL-specific model loading logic into the IDL loader and out of the LoaderVisitor. This cleans up the LoaderVisitor and also fixes a bug in how the `apply` statement wasn't properly resolving the targeted shape ID (it always assumed that the target was in the current namespace).
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures that JSON IDL models are loaded before IDL models to reduce forward reference lookups when loading IDL models.
Move IDL specific loading logic to IDL
This commit moves all IDL-specific model loading logic into the IDL loader and out of the LoaderVisitor. This cleans up the LoaderVisitor and also fixes a bug in how the
applystatement wasn't properly resolving the targeted shape ID (it always assumed that the target was in the current namespace).Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.