Conversation
When extending CodeWriter, you might need to also track state like imports in a corresponding stack. This is now possible since pushState and popState can be overridden.
This commit makes CodeWriter section interceptors deal with Object instead of String. This allows for the toString() method of the intercepted text to be wrapped by classes that extend from CodeWriter in order to determine if any side effects from the original content should take effect or be discarded. The general idea is that if toString() was called on the original content of an intercepted section, then original contents are also going to be written to the CodeWriter, meaning any side effects should also occur (for example, adding imports).
kstich
approved these changes
Oct 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make CodeWriters intercept Object instead of String
Allow pushState and popState to be overridden