Disable authentication on generated CORS options#179
Merged
JordonPhillips merged 1 commit intosmithy-lang:masterfrom Oct 4, 2019
Merged
Conversation
CORS preflight options checks are sent without authentication, and so the generated OPTIONS integrations should have an empty "security" list.
JordonPhillips
force-pushed
the
dont-authenticate-cors-options
branch
from
67661c9 to
9c9eca5
Compare
mtdowling
requested changes
Oct 3, 2019
smithy-openapi/src/main/java/software/amazon/smithy/openapi/model/OperationObject.java
Show resolved
Hide resolved
smithy-openapi/src/main/java/software/amazon/smithy/openapi/model/OperationObject.java
Show resolved
Hide resolved
mtdowling
approved these changes
Oct 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CORS preflight options checks are sent without authentication, and so
the generated OPTIONS integrations should have an empty
"security" list.
To enable this, I made the list of security settings an
Optionalto distinguish between an empty list and a list that wasn't set. This is a bit odd in terms of the rest of the code base where we simply don't serialize empty lists. It's needed so that we can special case the OPTIONS methods from the general "security" setting. The alternative is to explicitly set the "security" setting on every method, which seems like it would be error prone.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.