Skip to content

Support externalDocs when converting operations to OpenAPI#1767

Merged
JordonPhillips merged 1 commit intosmithy-lang:mainfrom
Xtansia:feat/support-externaldocs-operation
Jun 2, 2023
Merged

Support externalDocs when converting operations to OpenAPI#1767
JordonPhillips merged 1 commit intosmithy-lang:mainfrom
Xtansia:feat/support-externaldocs-operation

Conversation

@Xtansia
Copy link
Copy Markdown
Contributor

@Xtansia Xtansia commented May 11, 2023

Description of changes:

Supports converting the @externalDocumentation trait on operations into the externalDocs property when converting to OpenAPI.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Xtansia Xtansia requested a review from a team as a code owner May 11, 2023 00:19
@JordonPhillips JordonPhillips added the good-1st-issue Good for newcomers label Jun 2, 2023
@JordonPhillips
Copy link
Copy Markdown
Contributor

Thanks for the contribution! I was curious why we had that method if we weren't using it, but it turns out we do use it... on basically every other shape type. Whoops!

@JordonPhillips JordonPhillips merged commit d693438 into smithy-lang:main Jun 2, 2023
@Xtansia Xtansia deleted the feat/support-externaldocs-operation branch June 5, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good-1st-issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants