Allow member to inherit from more than one mixin#1715
Merged
sugmanue merged 2 commits intosmithy-lang:mainfrom Apr 5, 2023
Merged
Allow member to inherit from more than one mixin#1715sugmanue merged 2 commits intosmithy-lang:mainfrom
sugmanue merged 2 commits intosmithy-lang:mainfrom
Conversation
mtdowling
requested changes
Apr 4, 2023
| * | ||
| * @return Returns the optional member with the given name. | ||
| */ | ||
| public Optional<MemberShape> getMember(String memberName) { |
Member
There was a problem hiding this comment.
list and map should override this too I think
Contributor
Author
There was a problem hiding this comment.
Totally, let me update it.
mtdowling
approved these changes
Apr 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Allow multiple mixins to override the same member if they all target the same shape. This will allow the following example from the docs
To actually work as documented. This will also bring parity to the way mixins behave for top-level shapes, it will allow multiple mixins to override the same member provided that they all agree on the same target and will override traits with a last introduced wins policy.
Traits attached to each member will be overwritten by the last mixin or by the corresponding member in the shape. For instance, the following model
Will be flattened to the following shape:
Notice that the
tagstrait in theValidstructure will supersede the tags introduced by the mixin members.And the following model:
Will be flattened to the following shape:
Overriding the
@tagsin the order the mixins are processed, last wins.This change also forbids following the docs overriding using a different target, for instance
Will emit a validation error like:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.