Fix cp-R for linux, xcopy for windows in installers#1686
Merged
haydenbaker merged 2 commits intosmithy-lang:mainfrom Mar 17, 2023
Merged
Fix cp-R for linux, xcopy for windows in installers#1686haydenbaker merged 2 commits intosmithy-lang:mainfrom
haydenbaker merged 2 commits intosmithy-lang:mainfrom
Conversation
hpmellema
approved these changes
Mar 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
cpdiffer slightly in their (implementation of the-Roption)[https://dev.to/ackshaey/macos-vs-linux-the-cp-command-will-trip-you-up-2p00], this change addresses thatxcopywill succeed with path with double-trailing slashes (//) on Windows 11, but not on Windows server, this change addresses thatTesting:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.