Update protocol tests with int enum coverage#1492
Merged
haydenbaker merged 7 commits intosmithy-lang:mainfrom Nov 14, 2022
Merged
Update protocol tests with int enum coverage#1492haydenbaker merged 7 commits intosmithy-lang:mainfrom
haydenbaker merged 7 commits intosmithy-lang:mainfrom
Conversation
As part of IDL 2.0, the `intEnum` shape was added. The following changes add several test cases using an `intEnum` shape (and/or aggregates) under the `restJson1` protocol test suite. Included is a set of shared types, which target `intEnum` and aggregate-shapes of `intEnum`, and may be used in follow-up changes to other protocol test suites (awsJson*, *Query, etc.).
As part of IDL 2.0, the `intEnum` shape was added. The following changes add several test cases using an `intEnum` shape (and/or aggregates) under the `awsJson1_*`, *Query, and `RestXml` protocol test suites.
JordonPhillips
approved these changes
Nov 10, 2022
syall
suggested changes
Nov 10, 2022
Co-authored-by: Steven Yuan <s.yuan.all@gmail.com>
syall
approved these changes
Nov 10, 2022
syall
suggested changes
Nov 11, 2022
syall
suggested changes
Nov 11, 2022
syall
approved these changes
Nov 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
As part of IDL 2.0, the intEnum shape was added. The following changes add several test cases using an intEnum shape (and/or aggregates) under the protocols test suite. Included is a set of shared types, which target intEnum (or aggregate-shapes of intEnum).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.