Make string enum to enum shape transform opt-in in CodegenDirector#1370
Merged
gosar merged 1 commit intosmithy-lang:mainfrom Aug 29, 2022
Merged
Make string enum to enum shape transform opt-in in CodegenDirector#1370gosar merged 1 commit intosmithy-lang:mainfrom
gosar merged 1 commit intosmithy-lang:mainfrom
Conversation
mtdowling
approved these changes
Aug 26, 2022
gosar
added a commit
to gosar/smithy
that referenced
this pull request
Sep 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generators like smithy-typescript are affected by calling this transform. So making it opt-in, similar to createDedicatedInputsAndOutputs.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.