Update @httpResponseCode to not be applicable to @input structures#1359
Merged
syall merged 1 commit intosmithy-lang:mainfrom Aug 26, 2022
Merged
Conversation
syall
force-pushed
the
1105-make-httpresponsecode-not-worked-with-httperror
branch
from
0cf0c0c to
4342e23
Compare
...s/software/amazon/smithy/model/errorfiles/validators/http-response-code-input-conflicts.json
Outdated
Show resolved
Hide resolved
syall
force-pushed
the
1105-make-httpresponsecode-not-worked-with-httperror
branch
from
4342e23 to
a07475a
Compare
DavidOgunsAWS
approved these changes
Aug 26, 2022
- Changed the selector of `@httpResponseCode` to not select structures with the `@input` trait applied - Updated the docs for `@httpResponseCode` - Move `http-trait-conflicts` test to a `.smithy` file Resolves smithy-lang#1105
syall
force-pushed
the
1105-make-httpresponsecode-not-worked-with-httperror
branch
from
a07475a to
e0cd375
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1105
Description of changes:
Update
@httpResponseCodeto not be applicable to@inputstructures:@httpResponseCodeto not select structureswith the
@inputtrait applied@httpResponseCodeTesting:
Ran
./gradlew clean build check assemble --parallel --no-build-cache --no-daemonBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.