Forbid recursion through all required members#1200
Merged
Conversation
mtdowling
force-pushed
the
forbid-infinite-required-recursion
branch
2 times, most recently
from
93e48d8 to
addc198
Compare
This commit optimizes PathFinder.Path to be an internal linked list to reduce path copies while traversing potential recursive paths. This commit also fixes a bug where mutually recursive structures through optional members were erroneously flagged as invalid.
mtdowling
force-pushed
the
forbid-infinite-required-recursion
branch
from
addc198 to
89e12e9
Compare
kstich
approved these changes
Apr 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1183
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.