Implement comparable, add static compare method#1192
Merged
srchase merged 2 commits intosmithy-lang:mainfrom Apr 19, 2022
Merged
Implement comparable, add static compare method#1192srchase merged 2 commits intosmithy-lang:mainfrom
srchase merged 2 commits intosmithy-lang:mainfrom
Conversation
mtdowling
requested changes
Apr 16, 2022
smithy-model/src/main/java/software/amazon/smithy/model/SourceLocation.java
Outdated
Show resolved
Hide resolved
srchase
force-pushed
the
source-location-sorter
branch
from
6b539cc to
c3badd0
Compare
srchase
changed the title
srchase
force-pushed
the
source-location-sorter
branch
from
c3badd0 to
be278ba
Compare
srchase
changed the title
srchase
force-pushed
the
source-location-sorter
branch
from
be278ba to
c99fcaf
Compare
mtdowling
reviewed
Apr 18, 2022
smithy-model/src/main/java/software/amazon/smithy/model/FromSourceLocation.java
Outdated
Show resolved
Hide resolved
srchase
force-pushed
the
source-location-sorter
branch
from
c9ecec0 to
bb54034
Compare
mtdowling
approved these changes
Apr 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CR implements Comparable on SourceLocation and adds a
comparestatic method to FromSourceLocation for comparing SourceLocations.This can be used to compare and sort shapes or traits, replacing the
SourceLocationSorterandTraitSorteradded in #1175. It will also be used to sort shapes in the Smithy Language Server (smithy-lang/smithy-language-server#35).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.