Reset ModelAssembler's validationEventListener to default#1124
Merged
gosar merged 1 commit intosmithy-lang:mainfrom Mar 11, 2022
Merged
Reset ModelAssembler's validationEventListener to default#1124gosar merged 1 commit intosmithy-lang:mainfrom
gosar merged 1 commit intosmithy-lang:mainfrom
Conversation
gosar
commented
Mar 9, 2022
| assembler.assemble(); | ||
| } | ||
|
|
||
| // reset() affects multiple properties of the ModelAssembler. The test asserts one of them (shapes). |
Contributor
Author
There was a problem hiding this comment.
I didn't think it was worth asserting each property, by exposing a package-private access to each property, or a separate behavior test like below. LMK if you think otherwise.
kstich
approved these changes
Mar 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
resetDoesNotBarftest would throw NPE before the change and now passes.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.