Merged
Conversation
Rather than rely on a simple base interface for codegen settings, an unconstrained generic type parameter is now used. This removes any assumptions about how code is being generated across generators, and additional interfaces that try to unify generators could be added in the future as needed using things like intersection types.
kstich
approved these changes
Mar 3, 2022
JordonPhillips
approved these changes
Mar 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than rely on a simple base interface for codegen settings, an
unconstrained generic type parameter is now used. This removes any
assumptions about how code is being generated across generators, and
additional interfaces that try to unify generators could be added in the
future as needed using things like intersection types.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.