Add malformed request tests for more set types#1094
Merged
adamthom-amzn merged 1 commit intosmithy-lang:mainfrom Feb 17, 2022
Merged
Add malformed request tests for more set types#1094adamthom-amzn merged 1 commit intosmithy-lang:mainfrom
adamthom-amzn merged 1 commit intosmithy-lang:mainfrom
Conversation
adamthom-amzn
force-pushed
the
set-enhancemnts
branch
from
213d420 to
cccdf1d
Compare
gosar
approved these changes
Feb 16, 2022
Sets of blobs, dates, structures and documents are all valid, and may not be easily supported in all targeted server languages.
adamthom-amzn
force-pushed
the
set-enhancemnts
branch
from
cccdf1d to
8cfca9e
Compare
gosar
approved these changes
Feb 16, 2022
david-perez
approved these changes
Feb 17, 2022
Contributor
david-perez
left a comment
david-perez
left a comment
There was a problem hiding this comment.
Looks good! Thank you!
mtdowling
reviewed
Feb 18, 2022
| { | ||
| id: "RestJsonMalformedSetDuplicateDocuments", | ||
| documentation: """ | ||
| When the set has duplicated documents, the response should be a 400 |
Member
There was a problem hiding this comment.
Why not indent long strings to make it easier to see key value pairs?
Contributor
Author
There was a problem hiding this comment.
I copy and pasted the same mistake as the test above
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Sets of blobs, dates and documents are all valid, and may not be easily
supported in all targeted server languages.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.