Merged
Conversation
Member
|
I think setting the target branch to default-zero-value-docs would make this easier to review. |
Contributor
Author
That branch is on my fork, so that's not possible. Since there is only a singular unique commit, you can just click on it to review that commit. I could also just rebase on idl-2.0 but then there'd be a ton of broken links. |
mtdowling
requested changes
Jan 26, 2022
Member
There was a problem hiding this comment.
These members all need to be required... Might be nice to just trim down the example to one identifier too.
Contributor
Author
There was a problem hiding this comment.
How about two? I want there to be more than one to emphasize how annoying it is to copy and paste.
JordonPhillips
force-pushed
the
migration-guide
branch
2 times, most recently
from
807db1d to
3ad0754
Compare
mtdowling
approved these changes
Jan 29, 2022
mtdowling
approved these changes
Jan 31, 2022
JordonPhillips
force-pushed
the
migration-guide
branch
from
3ad0754 to
e765412
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based off of #1064, so only the last commit here needs to be looked at.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.