Add exact match configuration to repeated shape name validator#1041
Merged
JordonPhillips merged 2 commits intosmithy-lang:mainfrom Jan 10, 2022
Merged
Add exact match configuration to repeated shape name validator#1041JordonPhillips merged 2 commits intosmithy-lang:mainfrom
JordonPhillips merged 2 commits intosmithy-lang:mainfrom
Conversation
mtdowling
requested changes
Jan 7, 2022
kstich
requested changes
Jan 7, 2022
smithy-linters/src/main/java/software/amazon/smithy/linters/RepeatedShapeNameValidator.java
Outdated
Show resolved
Hide resolved
smithy-linters/src/main/java/software/amazon/smithy/linters/RepeatedShapeNameValidator.java
Outdated
Show resolved
Hide resolved
JordonPhillips
force-pushed
the
repeated-name
branch
from
804d6de to
9adbb31
Compare
This adds a configuration option to the repeating shape name validator to specify that it should be an exact match rather than a prefix check.
JordonPhillips
force-pushed
the
repeated-name
branch
from
9adbb31 to
b27a1e0
Compare
kstich
approved these changes
Jan 10, 2022
mtdowling
approved these changes
Jan 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a configuration option to the repeating shape name validator to specify that it should be an exact match rather than a prefix check.
This also deprecates the old validator in favor of the new one due to its less than ideal name.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.