Implement default value handling for IDL 2.0#1019
Merged
Conversation
JordonPhillips
requested changes
Dec 16, 2021
smithy-model/src/main/java/software/amazon/smithy/model/loader/LoaderUtils.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/loader/ModelAssembler.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/loader/ModelAssembler.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/loader/ModelLoader.java
Outdated
Show resolved
Hide resolved
kstich
reviewed
Dec 17, 2021
smithy-model/src/main/java/software/amazon/smithy/model/loader/ModelAssembler.java
Outdated
Show resolved
Hide resolved
kstich
reviewed
Dec 17, 2021
smithy-model/src/main/resources/software/amazon/smithy/model/loader/prelude.smithy
Outdated
Show resolved
Hide resolved
mtdowling
force-pushed
the
implement-default-trait
branch
from
b1b6f49 to
f73f66e
Compare
JordonPhillips
approved these changes
Dec 17, 2021
Contributor
JordonPhillips
left a comment
JordonPhillips
left a comment
There was a problem hiding this comment.
Still want to get that change to add more emphasis on IDL, but after that it's all good
mtdowling
force-pushed
the
implement-default-trait
branch
from
f73f66e to
ad53d6e
Compare
JordonPhillips
approved these changes
Dec 17, 2021
mtdowling
force-pushed
the
add-default-trait
branch
2 times, most recently
from
89f5117 to
989c90e
Compare
kstich
approved these changes
Dec 17, 2021
mtdowling
force-pushed
the
implement-default-trait
branch
from
ad53d6e to
208445f
Compare
mtdowling
force-pushed
the
add-default-trait
branch
from
989c90e to
c06f017
Compare
mtdowling
force-pushed
the
implement-default-trait
branch
from
208445f to
0162e0c
Compare
mtdowling
force-pushed
the
implement-default-trait
branch
from
0162e0c to
422ce5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.