Skip to content

Spring Framework example applications for balanced reader nodes #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2024
Merged

Spring Framework example applications for balanced reader nodes #852

merged 1 commit into from
Jan 31, 2024

Conversation

sergiyvamz
Copy link
Contributor

Summary

Spring Framework example applications for balanced reader nodes

Description

  • Add two example application with load balanced access to readers.
  • Added new configuration presets SF_ optimized for Spring Framework applications
  • Fixes in session state transfer

Additional Reviewers

@karenc-bq
@crystall-bitquill
@aaronchung-bitquill

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

brunos-bq
brunos-bq reviewed Jan 25, 2024
View reviewed changes
wrapper/src/main/java/software/amazon/jdbc/profile/ConfigurationProfilePresetCodes.java
@@ -52,6 +54,14 @@ public class ConfigurationProfilePresetCodes {
public static final String I0 = "I0"; // Normal
public static final String I1 = "I1"; // Aggressive

public static final String SF_D0 = "SF_D0"; // Normal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT:
what about SD0, or S_D0?
however, it would be nice to add an extra comment, to indicate whether S_D0 and D0 are related just with the addition of Spring Framework

Copy link
Contributor Author

@sergiyvamz sergiyvamz Jan 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 31 the same file?

// Presets family SF_D, SF_E ,SF_F - internal connection pool; optimized for Spring Framework / Spring Boot

wrapper/src/main/java/software/amazon/jdbc/states/SessionStateServiceImpl.java
}

@Override
public void setupPristineAutoCommit(final boolean autoCommit) throws SQLException {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make this parameter optional and then only have one setupPristineAutoCommit() function instead of two that do almost the same thing except in one line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect that it's be hard to distinguish the case when the value is explicitly provided from the case when the value is not provided and default value is used. For example, for setupPristingCatalog(String catalog), null is a legit value when it's provided.

@sergiyvamz sergiyvamz force-pushed the spring-readonly-example branch from f15df12 to 20fc1a3 Compare January 25, 2024 18:46
crystall-bitquill
crystall-bitquill reviewed Jan 25, 2024
View reviewed changes
@sergiyvamz sergiyvamz force-pushed the spring-readonly-example branch 4 times, most recently from 2eb594e to 38e67b0 Compare January 30, 2024 22:38
@sergiyvamz sergiyvamz force-pushed the spring-readonly-example branch from 38e67b0 to b90e454 Compare January 31, 2024 19:17
@sergiyvamz sergiyvamz merged commit d073fba into main Jan 31, 2024
@sergiyvamz sergiyvamz deleted the spring-readonly-example branch January 31, 2024 19:17
jasonli-improving pushed a commit to Bit-Quill/aws-advanced-jdbc-wrapper that referenced this pull request Feb 2, 2024
@sergiyvamz @jasonli-improving
Spring Framework example applications for balanced reader nodes (aws#852
4be33a7 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karenc-bq karenc-bq karenc-bq left review comments

@crystall-bitquill crystall-bitquill crystall-bitquill left review comments

@aaronchung-bitquill aaronchung-bitquill aaronchung-bitquill left review comments

+1 more reviewer

@brunos-bq brunos-bq brunos-bq left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sergiyvamz @brunos-bq @karenc-bq @crystall-bitquill @aaronchung-bitquill