fix: using masked properties for logging #723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiyvamz
reviewed
Nov 6, 2023
| @@ -96,7 +96,8 @@ public static void setPropertyOnTarget( | |||
| } else { | |||
| writeMethod.invoke(target, propValue); | |||
| } | |||
| LOGGER.finest(() -> String.format("Set property '%s' with value: %s", propName, propValue)); | |||
| Object loggedProperty = propValue.equals(PropertyDefinition.PASSWORD.name) ? "***" : propValue; | |||
There was a problem hiding this comment.
I'd extract a code that check if the property contains a secret into a separate function and use it everywhere here in PropertyUtils
sergiyvamz
reviewed
Nov 6, 2023
| @@ -127,6 +134,10 @@ public static void setPropertyOnTarget( | |||
| return copy; | |||
| } | |||
|
|
|||
| public static boolean isSecretProperty(final Object propertyKey) { | |||
sergiyvamz
approved these changes
Nov 6, 2023
karenc-bq
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix: using masked properties for logging
Additional Reviewers
@sergiyv-improving
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.