feat: ELB URL support #476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crystall-bitquill
force-pushed
the
elb-url-support
branch
from
b385475 to
3b6285d
Compare
karenc-bq
reviewed
Jun 6, 2023
| @@ -23,6 +23,7 @@ public enum RdsUrlType { | |||
| RDS_CUSTOM_CLUSTER(true, true), | |||
| RDS_PROXY(true, false), | |||
| RDS_INSTANCE(true, false), | |||
| ELB(false, false), | |||
There was a problem hiding this comment.
Do we actually need an ELB type? Can it just go into the "OTHER" category
karenc-bq
approved these changes
Jun 6, 2023
crystall-bitquill
force-pushed
the
elb-url-support
branch
from
3b6285d to
a4c52f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Elastic Load Balancer URL support
Description
Added an ELB pattern to match URL formatting and to obtain the AWS region from the URL.
Additional Reviewers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.