feat: add a middleware inserting right host header#567
Merged
trivikr merged 2 commits intoaws:smithy-codegenfrom Dec 19, 2019
Merged
feat: add a middleware inserting right host header#567trivikr merged 2 commits intoaws:smithy-codegenfrom
trivikr merged 2 commits intoaws:smithy-codegenfrom
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AllanZhengYP
added
the
smithy-codegen
trivikr
requested changes
Dec 19, 2019
Member
trivikr
left a comment
trivikr
left a comment
There was a problem hiding this comment.
LGTM, just a suggestion to change metadata from an array to object
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AllanZhengYP
force-pushed
the
add-host-middleware
branch
from
9ccd60f to
4c8361d
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
trivikr
approved these changes
Dec 19, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
metadataproperty toRequestHandlerinterface that contains self-describing information of the handler. In this case, Node H1 handler and Node H2 handler can identify themselves as for H1 request or H2 request.hostheader or:authorityheader respectively, according toRequestHandler'smetadatafor H1 or H2. Separating this functionality from SignatureV4 signer because Node H2 doesn't allow sendinghostheader in H2 request specificly, so the signer shouldn't add thehostheader blindly.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.