fix: support custom agent in node http handler#489
Merged
AllanZhengYP merged 3 commits intoaws:smithy-codegenfrom Dec 5, 2019
Merged
fix: support custom agent in node http handler#489AllanZhengYP merged 3 commits intoaws:smithy-codegenfrom
AllanZhengYP merged 3 commits intoaws:smithy-codegenfrom
Conversation
Because these interfaces are constructor interface for individual http handler, they only need to be exposed from its own http handler package
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Codecov Report
@@ Coverage Diff @@
## smithy-codegen #489 +/- ##
==================================================
+ Coverage 94.53% 94.54% +<.01%
==================================================
Files 68 68
Lines 1282 1284 +2
Branches 255 256 +1
==================================================
+ Hits 1212 1214 +2
Misses 70 70
Continue to review full report at Codecov.
|
srchase
approved these changes
Dec 4, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change also clean up the request options interfaces. Now we only pulish
httpHandlerOptionsinterface which defines the per-request http options. It currently only has anAbortSignalentry. The other interface are removed from@aws-sdk/typesbecause these interfaces are constructor interface for individual http handler, they only need to be exposed from its own http handler package.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.