feat(packages): end support for Node.js 10.x#3141
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3141 +/- ##
=======================================
Coverage 75.19% 75.19%
=======================================
Files 474 474
Lines 20724 20724
Branches 4756 4756
=======================================
Hits 15584 15584
Misses 5140 5140 Continue to review full report at Codecov.
|
AllanZhengYP
approved these changes
Jan 6, 2022
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
We announced the end of support for Node.js 10.x in the AWS SDK for JavaScript (v3) starting January 1, 2022 back in July.
The value for engines.node was bumped for clients in #3122, but was missed for non-clients.
Description
Bump engines to node >=12.0.0 in package.json for non-clients
Testing
N/A
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.