Conversation
|
CI is broken for ts-node: |
|
Bumped the node.js in runtime from 10 to 12 to fix the issue |
tests/versions/tslib.ts
Outdated
|
|
||
| console.log("Validating the tslib and tsc version is consistent within workspace."); | ||
| const expectedVersions: { [name: string]: string } = JSON.parse(readFileSync(join(__dirname, "versions.json"), "utf8")); | ||
| const packagesInfo: PackageInfo[] = JSON.parse(execSync("./node_modules/.bin/lerna list -l --json").toString()); |
There was a problem hiding this comment.
Instead of calling lerna with execSync, should we call subdirectories of workspaces listed in root package.json?
That way, we won't have a dependency on lerna from the test code.
|
The code change to upgrade tslib version looks good to me. |
Codecov Report
@@ Coverage Diff @@
## main #2601 +/- ##
=======================================
Coverage ? 60.33%
=======================================
Files ? 516
Lines ? 27450
Branches ? 6595
=======================================
Hits ? 16561
Misses ? 10889
Partials ? 0 Continue to review full report at Codecov.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
5 participants
Issue
Resolves #2587
Resolves #2582
Description
"^2.0.0"to^2.3.0By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.